chore(create-vite): move common ts settings to base tsconfig
#19228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmal
force-pushed
the
fmal/patch-94089
branch
from
bd2a88d to
0a13901
Compare
|
if this is motivated by DRY principles, i would ask to reconsider. Sharing compilerOptions between different config files that target different parts of an application should only be done because they are connected in that sense and you want to be able to have this file as a shared source of truth to prevent having to edit a compiler option in 2 places instead of one. Creating a more complex extends chain is not only less tracable for human reading but also adds (a little) overhead to tsconfck for parsing these. |
|
Also keep in mind that these starters are intended to be a minimal starting point and carry little to no opinion and avoid complexity where possible. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Discussed this briefly with @ArnaudBarre on Discord, this is a proposal to avoid duplication between tsconfigs.
Some Vite starter templates with typescript include
tsconfig.jsonthat referencestsconfig.app.jsonandtsconfig.node.json. A lot of settings betweenappandnodeconfigs are repeated. This PR moves shared config props to roottsconfig.jsonand makestsconfig.app.jsonandtsconfig.node.jsinheritcompilerOptionsfrom it.This works because
referencesare excluded from inheritance (see https://www.typescriptlang.org/tsconfig/#extends)